Review Request 108571: Allow a separate config for group chats

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108571/#review27323
-----------------------------------------------------------



config/appearance-config-tab.h
<http://git.reviewboard.kde.org/r/108571/#comment20553>

    White spaces (here and in other places in this file)



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment20556>

    It would be great to have a sendGroupDemoMessages, you can "steal" it from here: https://git.reviewboard.kde.org/r/107132/diff/#index_header



config/appearance-config-tab.cpp
<http://git.reviewboard.kde.org/r/108571/#comment20555>

    Perhaps this method could accept a string with the theme name, so that you can have different defaults for single and group chats



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/108571/#comment20554>

    This should be SimKete for group chat, so perhaps you should move this inside the previous if


- Daniele E. Domenichelli


On Feb. 12, 2013, 4:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108571/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 4:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Allow a separate config for group chats
> 
> Work by our code-in student Huba Nagy. I've not reviewed it myself.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 8e685323477442c2825ab543c19b9708d1264783 
>   config/CMakeLists.txt 24e9e80ffd9c23515a457a5d2f0ba8271e207e17 
>   config/appearance-config-tab.h PRE-CREATION 
>   config/appearance-config-tab.cpp PRE-CREATION 
>   config/appearance-config.h 5b6c83d6ac4001f1d28b3ce1cb8e18a38e5269c5 
>   config/appearance-config.cpp a88dd028a2ec46f0b945ee3297659ce4410895ee 
>   lib/adium-theme-view.cpp 7fa3b06480e5990e03dc15b5859c49e51b7d4642 
> 
> Diff: http://git.reviewboard.kde.org/r/108571/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130212/52510ffe/attachment.html>