Review Request 107132: Do not hardcode group chat theme

[Dan Vrátil]

> On Oct. 31, 2012, 3:12 p.m., Dan Vrátil wrote:
> > I'd prefer to have a separate component right away, rather then hacking it now and waiting for someone else to clean it up.
> > 
> > One issue I've run to: I set Renkoo as group chat theme, reopened the Settings dialog, went to the Group chat tab again and the preview was not populated (this does not happen with SimKete though). I don't know whether this is caused by the Renkoo theme, but it might indicate problem in our code (I don't have any other themes to test right now). This does not happen in the "Single chat" tab.
> 
> Daniele E. Domenichelli wrote:
>     I didn't have any issue like that, does it happen every time and/or with any other theme?
>     I *think* that the Renkoo theme is broken for group chats though...
> 
> David Edmundson wrote:
>     It's not "broken". It's just useless as you can't see who' sending you messages (especially if no-one has an avatar)
> 
> Dan Vrátil wrote:
>     I installed some additional themes and I was unable to reproduce it with any of them. And after changing "Single chat" theme, I was unable to reproduce it even with Renkoo, so I guess it's just some weird coincidental thingie.

Should this review be discarded in favour of https://git.reviewboard.kde.org/r/108571/ ?


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107132/#review21224
-----------------------------------------------------------


On Nov. 10, 2012, 12:22 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107132/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 12:22 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is a quick and dirty way to fix it, basically I duplicated the code for the single user chat and added a tabbed view.
> Perhaps it could be a widget in order to avoid code duplication, but since we have just 2, I'd leave it like this for now, so that we can configure this in 0.6, and perhaps open a junior-job bug for this
> 
> 
> This addresses bugs 282518 and 295843.
>     http://bugs.kde.org/show_bug.cgi?id=282518
>     http://bugs.kde.org/show_bug.cgi?id=295843
> 
> 
> Diffs
> -----
> 
>   config/appearance-config.ui 7fe6ce43a952652edcca229b918283b05268b240 
>   lib/adium-theme-view.cpp 24b9c3570699f64e1b751183430e4975dc6a449d 
>   config/appearance-config.h 5b6c83d6ac4001f1d28b3ce1cb8e18a38e5269c5 
>   config/appearance-config.cpp 7f42857998b509a03dc8168181850a7a9a2a477d 
> 
> Diff: http://git.reviewboard.kde.org/r/107132/diff/
> 
> 
> Testing
> -------
> 
> Config works, group chat works
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130211/a3f60cb4/attachment.html>