Review Request 108900: add some actions to ktp-debugger
Aleix Pol Gonzalez
aleixpol at gmail.com
Mon Feb 11 18:09:16 UTC 2013
> On Feb. 11, 2013, 2:01 p.m., Rohan Garg wrote:
> > tools/debugger/debug-message-view.cpp, line 212
> > <http://git.reviewboard.kde.org/r/108900/diff/1/?file=113532#file113532line212>
> >
> > How about using a QScopedPointer here? then you don't have to delete the pointer manually.
I don't really feel discussing this would make any better for KTP Debugger. Yes, I could use that or explicitly call delete... :/
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108900/#review27204
-----------------------------------------------------------
On Feb. 11, 2013, 1:59 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108900/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2013, 1:59 a.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Description
> -------
>
> makes it possible to:
> - search in the current log
> - add a mark at any moment
>
>
> Diffs
> -----
>
> tools/debugger/debug-message-view.h 837b6bf
> tools/debugger/debug-message-view.cpp d31f0c2
> tools/debugger/main-window.cpp 7b95cd9
>
> Diff: http://git.reviewboard.kde.org/r/108900/diff/
>
>
> Testing
> -------
>
> tested the ui...
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130211/022742af/attachment-0001.html>
More information about the KDE-Telepathy
mailing list