Review Request 108900: add some actions to ktp-debugger

Rohan Garg rohangarg at kubuntu.org
Mon Feb 11 14:01:38 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108900/#review27204
-----------------------------------------------------------



tools/debugger/debug-message-view.cpp
<http://git.reviewboard.kde.org/r/108900/#comment20486>

    How about using a QScopedPointer here? then you don't have to delete the pointer manually.


- Rohan Garg


On Feb. 11, 2013, 7:29 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108900/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 7:29 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> makes it possible to:
> - search in the current log
> - add a mark at any moment
> 
> 
> Diffs
> -----
> 
>   tools/debugger/debug-message-view.h 837b6bf 
>   tools/debugger/debug-message-view.cpp d31f0c2 
>   tools/debugger/main-window.cpp 7b95cd9 
> 
> Diff: http://git.reviewboard.kde.org/r/108900/diff/
> 
> 
> Testing
> -------
> 
> tested the ui...
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130211/39832805/attachment.html>


More information about the KDE-Telepathy mailing list