Review Request 108830: Make Qt::DisplayRole compare the same as default

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108830/#review26852
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On Feb. 7, 2013, 2:03 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108830/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 2:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Comparing the Qt::DisplayRole is basically the same as comparing default, except we're querying the model once more even if we already have the needed strings, so let's reuse that. Also fixes a huge and super annoying problem when the Qt::DisplayRole was comparing the same strings.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-filter-model.cpp f0372b4 
> 
> Diff: http://git.reviewboard.kde.org/r/108830/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130207/6799329a/attachment.html>