Review Request 108830: Make Qt::DisplayRole compare the same as default

Martin Klapetek martin.klapetek at gmail.com
Thu Feb 7 13:03:17 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108830/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Comparing the Qt::DisplayRole is basically the same as comparing default, except we're querying the model once more even if we already have the needed strings, so let's reuse that. Also fixes a huge and super annoying problem when the Qt::DisplayRole was comparing the same strings.


Diffs
-----

  KTp/Models/contacts-filter-model.cpp f0372b4 

Diff: http://git.reviewboard.kde.org/r/108830/diff/


Testing
-------

Yes.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130207/e881cb02/attachment.html>


More information about the KDE-Telepathy mailing list