Review Request 108790: Add a class to instantly access the grouped, filtered contacts list model without having to handle proxies ourselves

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108790/#review26650
-----------------------------------------------------------



KTp/Models/contacts-model.h
<http://git.reviewboard.kde.org/r/108790/#comment20242>

    Not needed



KTp/Models/contacts-model.h
<http://git.reviewboard.kde.org/r/108790/#comment20243>

    Not needed



KTp/Models/contacts-model.h
<http://git.reviewboard.kde.org/r/108790/#comment20241>

    put }; on new line



KTp/Models/contacts-model.h
<http://git.reviewboard.kde.org/r/108790/#comment20240>

    Should this be a Q_PROPERTY?



KTp/Models/contacts-model.cpp
<http://git.reviewboard.kde.org/r/108790/#comment20244>

    Shouldn't this be called after you call d->source->setAccountManager()?



KTp/Models/contacts-model.cpp
<http://git.reviewboard.kde.org/r/108790/#comment20245>

    Would it make sense for the sake of performance to just return if d->groupMode == mode ? You could reinitalize the AccountTreeProxyModel manually in setAccountManager().


- Dan Vrátil


On Feb. 5, 2013, 12:02 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108790/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 12:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add a class to instantly access the grouped, filtered contacts list model without having to handle proxies manually.
> This was previously used in ktp-contact-list during porting. 
> 
> Longer term this will also handle including the MessageModelSource proxy, and possible KPeople.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt a95e0c19c816f0cb8a465614fa7e1adecb6d58d1 
>   KTp/Models/contacts-model.h 2a9cf44736e6e3aea5f92eb09e6840314ba94247 
>   KTp/Models/contacts-model.cpp 5eb37b1755d3b69961fbed4131ab470c252a29ba 
> 
> Diff: http://git.reviewboard.kde.org/r/108790/diff/
> 
> 
> Testing
> -------
> 
> Used in the contact-list for a month :)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130204/8c65c4a5/attachment-0001.html>