Review Request 108790: Add a class to instantly access the grouped, filtered contacts list model without having to handle proxies ourselves
David Edmundson
david at davidedmundson.co.uk
Mon Feb 4 23:03:02 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108790/#review26649
-----------------------------------------------------------
KTp/Models/contacts-model.h
<http://git.reviewboard.kde.org/r/108790/#comment20238>
Close, but slightly out of date
KTp/Models/contacts-model.cpp
<http://git.reviewboard.kde.org/r/108790/#comment20239>
Missing license, not even close.
- David Edmundson
On Feb. 4, 2013, 11:02 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108790/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2013, 11:02 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Add a class to instantly access the grouped, filtered contacts list model without having to handle proxies manually.
> This was previously used in ktp-contact-list during porting.
>
> Longer term this will also handle including the MessageModelSource proxy, and possible KPeople.
>
>
> Diffs
> -----
>
> KTp/Models/CMakeLists.txt a95e0c19c816f0cb8a465614fa7e1adecb6d58d1
> KTp/Models/contacts-model.h 2a9cf44736e6e3aea5f92eb09e6840314ba94247
> KTp/Models/contacts-model.cpp 5eb37b1755d3b69961fbed4131ab470c252a29ba
>
> Diff: http://git.reviewboard.kde.org/r/108790/diff/
>
>
> Testing
> -------
>
> Used in the contact-list for a month :)
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130204/d44fd67c/attachment.html>
More information about the KDE-Telepathy
mailing list