Review Request 114515: Make KTp kpeople ID include the accountID

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114515/#review45875
-----------------------------------------------------------


Thread 1 (Thread 0x7fc1a4caa780 (LWP 27322)):
[KCrash Handler]
#6  Tp::DBusProxy::objectPath (this=0x0) at /home/david/projects/kde4/src/telepathy-qt/TelepathyQt/dbus-proxy.cpp:131
#7  0x00007fc1a2f144a4 in Tp::Account::uniqueIdentifier (this=<optimized out>) at /home/david/projects/kde4/src/telepathy-qt/TelepathyQt/account.cpp:2094
#8  0x00007fc1a48a1f1c in KTpAllContacts::createUri (this=this at entry=0x1906b30, contact=...) at /home/david/projects/kde4/src/extragear/network/telepathy/ktp-common-internals/KTp/im-persons-data-source.cpp:76
#9  0x00007fc1a48a284b in KTpAllContacts::onContactInvalidated (this=0x1906b30) at /home/david/projects/kde4/src/extragear/network/telepathy/ktp-common-internals/KTp/im-persons-data-source.cpp:140

I remember DrDanz doing this same change once, and I rejected it saying this could happen. 
Bother. 

- David Edmundson


On Dec. 17, 2013, 11:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114515/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 11:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Make KTp kpeople ID include the accountID
> 
> 
> Reduce warnings; don't try to access allKnownContacts till connection is ready
> 
> 
> Diffs
> -----
> 
>   KTp/global-contact-manager.cpp eec0d4f 
>   KTp/im-persons-data-source.cpp 13345a6 
> 
> Diff: http://git.reviewboard.kde.org/r/114515/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131217/715ebaee/attachment.html>