<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114515/">http://git.reviewboard.kde.org/r/114515/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thread 1 (Thread 0x7fc1a4caa780 (LWP 27322)):
[KCrash Handler]
#6 Tp::DBusProxy::objectPath (this=0x0) at /home/david/projects/kde4/src/telepathy-qt/TelepathyQt/dbus-proxy.cpp:131
#7 0x00007fc1a2f144a4 in Tp::Account::uniqueIdentifier (this=<optimized out>) at /home/david/projects/kde4/src/telepathy-qt/TelepathyQt/account.cpp:2094
#8 0x00007fc1a48a1f1c in KTpAllContacts::createUri (this=this@entry=0x1906b30, contact=...) at /home/david/projects/kde4/src/extragear/network/telepathy/ktp-common-internals/KTp/im-persons-data-source.cpp:76
#9 0x00007fc1a48a284b in KTpAllContacts::onContactInvalidated (this=0x1906b30) at /home/david/projects/kde4/src/extragear/network/telepathy/ktp-common-internals/KTp/im-persons-data-source.cpp:140
I remember DrDanz doing this same change once, and I rejected it saying this could happen.
Bother. </pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On December 17th, 2013, 11:11 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2013, 11:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make KTp kpeople ID include the accountID
Reduce warnings; don't try to access allKnownContacts till connection is ready
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/global-contact-manager.cpp <span style="color: grey">(eec0d4f)</span></li>
<li>KTp/im-persons-data-source.cpp <span style="color: grey">(13345a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>