Review Request 114418: Correctly wipe and rebuild the contact details widget in PersonDetailsView.

[Aleix Pol Gonzalez]

> On Dec. 12, 2013, 6:20 p.m., Martin Klapetek wrote:
> > src/widgets/persondetailsview.cpp, line 108
> > <http://git.reviewboard.kde.org/r/114418/diff/1/?file=224598#file224598line108>
> >
> >     Can a widget be parent to itself?

Well, here it's not itself the parent, it's just passing a pointer full of uninitialized garbage from the cyberspace. :D


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114418/#review45611
-----------------------------------------------------------


On Dec. 12, 2013, 6 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114418/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 6 p.m.)
> 
> 
> Review request for Telepathy and Dan Vrátil.
> 
> 
> Repository: libkpeople
> 
> 
> Description
> -------
> 
> Correctly wipe and rebuild the contact details widget in PersonDetailsView.
> 
> Adding Dan to the list because I know he was going to look into it at one point (AFAIK he hasn't started yet)
> 
> 
> Diffs
> -----
> 
>   src/plugins/akonadi/akonadidatasource.cpp 8b5fad7 
>   src/widgets/persondetailsview.cpp 3edd145 
> 
> Diff: http://git.reviewboard.kde.org/r/114418/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131212/70a35b4e/attachment.html>