Review Request 114418: Correctly wipe and rebuild the contact details widget in PersonDetailsView.
Martin Klapetek
martin.klapetek at gmail.com
Thu Dec 12 18:20:47 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114418/#review45611
-----------------------------------------------------------
Ship it!
Looks good!
src/widgets/persondetailsview.cpp
<http://git.reviewboard.kde.org/r/114418/#comment32550>
Can a widget be parent to itself?
- Martin Klapetek
On Dec. 12, 2013, 6 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114418/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 6 p.m.)
>
>
> Review request for Telepathy and Dan Vrátil.
>
>
> Repository: libkpeople
>
>
> Description
> -------
>
> Correctly wipe and rebuild the contact details widget in PersonDetailsView.
>
> Adding Dan to the list because I know he was going to look into it at one point (AFAIK he hasn't started yet)
>
>
> Diffs
> -----
>
> src/plugins/akonadi/akonadidatasource.cpp 8b5fad7
> src/widgets/persondetailsview.cpp 3edd145
>
> Diff: http://git.reviewboard.kde.org/r/114418/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131212/8df8e57d/attachment.html>
More information about the KDE-Telepathy
mailing list