Review Request 114415: KTp-kded: Refactor in MPRIS - Use QDBusMessage instead of QDBusInterface.
David Edmundson
david at davidedmundson.co.uk
Wed Dec 11 21:28:07 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114415/#review45577
-----------------------------------------------------------
Ship it!
Can you push this into the 0.7 branch too please.
- David Edmundson
On Dec. 11, 2013, 9:09 p.m., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114415/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 9:09 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 328453
> http://bugs.kde.org/show_bug.cgi?id=328453
>
>
> Repository: ktp-kded-module
>
>
> Description
> -------
>
> TelepathyMPRIS: Refactor in requestPlaybackStatus().
>
> Use QDBusMessage instead of QDBusInterface.
>
>
> Diffs
> -----
>
> telepathy-mpris.cpp 529a100
>
> Diff: http://git.reviewboard.kde.org/r/114415/diff/
>
>
> Testing
> -------
>
> All works just like before patch, but bit faster (Speedup from 3 ms to 0 ms for requestPlaybackStatus() call).
>
>
> Thanks,
>
> Alexandr Akulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131211/7603803c/attachment.html>
More information about the KDE-Telepathy
mailing list