Review Request 114415: KTp-kded: Refactor in MPRIS - Use QDBusMessage instead of QDBusInterface.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114415/#review45576
-----------------------------------------------------------

Ship it!


Thanks

The speedup is because "QDBusInterface mprisInterface(..)" is a sync call, so it always blocks waiting for DBus reply.

- Martin Klapetek


On Dec. 11, 2013, 9:09 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114415/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 9:09 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 328453
>     http://bugs.kde.org/show_bug.cgi?id=328453
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> TelepathyMPRIS: Refactor in requestPlaybackStatus().
>     
> Use QDBusMessage instead of QDBusInterface.
> 
> 
> Diffs
> -----
> 
>   telepathy-mpris.cpp 529a100 
> 
> Diff: http://git.reviewboard.kde.org/r/114415/diff/
> 
> 
> Testing
> -------
> 
> All works just like before patch, but bit faster (Speedup from 3 ms to 0 ms for requestPlaybackStatus() call).
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131211/8894daba/attachment.html>