Review Request 112354: Add "share document" action to text-ui

Sven Brauch svenbrauch at gmx.de
Thu Aug 29 15:08:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112354/
-----------------------------------------------------------

(Updated Aug. 29, 2013, 3:08 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Do what David said.
See also the request for ktp-common-internals I'll submit in a moment.


Description
-------

This adds a "Share document" action to the text-ui.

The action is automatically enabled only if both contacts actually support the service. Otherwise, a tooltip is shown giving a hint on what to do to enable it.


Diffs (updated)
-----

  app/chat-window.h 30981d0 
  app/chat-window.cpp c698204 
  app/chatwindow.rc 01c27c5 

Diff: http://git.reviewboard.kde.org/r/112354/diff/


Testing
-------


File Attachments
----------------

both you and the contact support the service
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/29/possible.png
you or the target contact does not support the service
  http://git.reviewboard.kde.org/media/uploaded/files/2013/08/29/not-possible.png


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130829/70b10345/attachment.html>


More information about the KDE-Telepathy mailing list