Review Request 112354: Add "share document" action to text-ui

[Sven Brauch]

> On Aug. 29, 2013, 12:57 p.m., David Edmundson wrote:
> > app/chat-window.cpp, line 361
> > <http://git.reviewboard.kde.org/r/112354/diff/1/?file=185568#file185568line361>
> >
> >     That's a crash in group chats
> >     
> >     targetContact will be null.
> >     
> >

Yes I noticed, I forgot about group chats somehow ;)


> On Aug. 29, 2013, 12:57 p.m., David Edmundson wrote:
> > app/fileShareRequest.h, line 89
> > <http://git.reviewboard.kde.org/r/112354/diff/1/?file=185570#file185570line89>
> >
> >     why have this then.
> >     
> >     In this situation we would create a room, and use that.

Right, that's what this function was supposed to do, once. :D
I'll remove it for now.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112354/#review38840
-----------------------------------------------------------


On Aug. 29, 2013, 10:28 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112354/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 10:28 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> This adds a "Share document" action to the text-ui.
> 
> The action is automatically enabled only if both contacts actually support the service. Otherwise, a tooltip is shown giving a hint on what to do to enable it.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 30981d0 
>   app/chat-window.cpp c698204 
>   app/chatwindow.rc 01c27c5 
>   app/fileShareRequest.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112354/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> both you and the contact support the service
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/29/possible.png
> you or the target contact does not support the service
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/29/not-possible.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130829/337a76ee/attachment-0001.html>