Review Request 112189: Don't stop logs import on error

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112189/#review38293
-----------------------------------------------------------

Ship it!


Forgot to click Ship it. Above suggestion is somewhat minor

- David Edmundson


On Aug. 21, 2013, 4:28 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112189/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 4:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Documentation to KTp::LogsImporter clearly states that when error() signal, the import can still continue importing further logs, so quitting in onError() slot is just stupid. The awkward part is that I've written both code.
> 
> This makes the previous review for KTp::LogsImporter unnecessary (it won't crash because KCM won't delete the importer until it emits finished()), but the code there is still broken, so let's fix it anyway.
> 
> 
> This addresses bug 323821.
>     http://bugs.kde.org/show_bug.cgi?id=323821
> 
> 
> Diffs
> -----
> 
>   src/kcm-telepathy-accounts.h 665152f 
>   src/kcm-telepathy-accounts.cpp d17efae 
> 
> Diff: http://git.reviewboard.kde.org/r/112189/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130821/32bd1b54/attachment.html>