Review Request 112189: Don't stop logs import on error

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112189/#review38291
-----------------------------------------------------------



src/kcm-telepathy-accounts.h
<http://git.reviewboard.kde.org/r/112189/#comment28309>

    indent
    
    (though if you read the next comment, you can drop these changes anyway)



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/112189/#comment28308>

    I would use QScopedPointer here, it makes the deletion clearer and saves you having a member variable.
    
    you have a .exec() on here anyway, so it's not going to live past this function.
    
    If you did remove the async you'd then have a new problem that you have an issue if someone added two accounts and added one before the first import finished.


- David Edmundson


On Aug. 21, 2013, 4:28 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112189/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 4:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Documentation to KTp::LogsImporter clearly states that when error() signal, the import can still continue importing further logs, so quitting in onError() slot is just stupid. The awkward part is that I've written both code.
> 
> This makes the previous review for KTp::LogsImporter unnecessary (it won't crash because KCM won't delete the importer until it emits finished()), but the code there is still broken, so let's fix it anyway.
> 
> 
> This addresses bug 323821.
>     http://bugs.kde.org/show_bug.cgi?id=323821
> 
> 
> Diffs
> -----
> 
>   src/kcm-telepathy-accounts.h 665152f 
>   src/kcm-telepathy-accounts.cpp d17efae 
> 
> Diff: http://git.reviewboard.kde.org/r/112189/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130821/aba16020/attachment.html>