Review Request 112006: Port LogViewer to KTp Logger

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112006/#review37866
-----------------------------------------------------------


Mostly awesome.
I think my comments in the other review will force you to redo part of this.

Otherwise, "Ship it!"


logviewer/entity-proxy-model.h
<http://git.reviewboard.kde.org/r/112006/#comment28034>

    NO!
    
    You must specify both years, not just change it.



logviewer/message-view.cpp
<http://git.reviewboard.kde.org/r/112006/#comment28035>

    ??


- David Edmundson


On Aug. 13, 2013, 7:51 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112006/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 7:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It's 1:1 change from TpLoggerQt to KTp Logger. Everything seems to work.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 55fc4b99fa6fdfac05a8b965d7f1c4dadc5339c5 
>   cmake/modules/FindKTp.cmake 8facd12f3d1f0940a205a5cb1e7ab64a7c1af2d8 
>   lib/CMakeLists.txt c73de90b9301645fc5c7183c246e975127141eb1 
>   lib/logmanager.h 61a5b04459128effd252953157140c0e633275f3 
>   lib/logmanager.cpp 946b08336ad8f6496006eaa800deb1a008524268 
>   lib/logmanager_dummy.cpp bf1180905dec72faf116ee8f1175067b16dd207e 
>   logviewer/CMakeLists.txt d01d7e16b79032efd3cbd98b4ffaa89fc2267067 
>   logviewer/conversation-date-picker.h d39e68d8e99809c5f00a69d1e51010612341b7b9 
>   logviewer/conversation-date-picker.cpp c3c31eca666227e9bd7d856b4a0aaafb3d7782d5 
>   logviewer/entity-model-item.h 87139567f319e9dc73c7384db035f4e756ab3075 
>   logviewer/entity-model-item.cpp b5ace64631d985e9edcd120c4435e575c4fa7874 
>   logviewer/entity-model.h 37cdeae3e884e93026bc29a80795edb109f01047 
>   logviewer/entity-model.cpp 4f0dc496896858dfb9f1aef4cb8ec1f46bacd125 
>   logviewer/entity-proxy-model.h 78dd07190c9c2d3de37a60e0aca8f5f9d825713c 
>   logviewer/entity-proxy-model.cpp e8c440ea900fd605064ad259201b60afed51f2a0 
>   logviewer/entity-view.cpp 97e7087a8e98348db7ed4ddd13becf895ce8623e 
>   logviewer/log-viewer.h f5f512ffada33bffb39763c3efc569551d41d17b 
>   logviewer/log-viewer.cpp 6fca33d6d9319a1f2a8f3aafe8ac47624de436c3 
>   logviewer/main.cpp be894c52fcbbcc3feb1c503485518dbcd3aae1f5 
>   logviewer/message-view.h 4dcf49cb851714a6279eebd4443bac089aca8ec8 
>   logviewer/message-view.cpp 13a67d9d55c76ab4b4df12d6a435a9edee440e32 
> 
> Diff: http://git.reviewboard.kde.org/r/112006/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130815/bc4bde82/attachment.html>