<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112006/">http://git.reviewboard.kde.org/r/112006/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mostly awesome.
I think my comments in the other review will force you to redo part of this.
Otherwise, "Ship it!"</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112006/diff/2/?file=179299#file179299line2" style="color: black; font-weight: bold; text-decoration: underline;">logviewer/entity-proxy-model.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright (C) 201<span class="hl">2</span> by Dan Vratil <dan@progdan.cz> *</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright (C) 201<span class="hl">3</span> by Dan Vratil <dan@progdan.cz> *</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">NO!
You must specify both years, not just change it.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112006/diff/2/?file=179306#file179306line151" style="color: black; font-weight: bold; text-decoration: underline;">logviewer/message-view.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MessageView::processStoredEvents()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qSort</span><span class="p">(</span><span class="n">m_events</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"><span class="hl">//</span> qSort(m_events);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">??</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On August 13th, 2013, 7:51 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2013, 7:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's 1:1 change from TpLoggerQt to KTp Logger. Everything seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(55fc4b99fa6fdfac05a8b965d7f1c4dadc5339c5)</span></li>
<li>cmake/modules/FindKTp.cmake <span style="color: grey">(8facd12f3d1f0940a205a5cb1e7ab64a7c1af2d8)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(c73de90b9301645fc5c7183c246e975127141eb1)</span></li>
<li>lib/logmanager.h <span style="color: grey">(61a5b04459128effd252953157140c0e633275f3)</span></li>
<li>lib/logmanager.cpp <span style="color: grey">(946b08336ad8f6496006eaa800deb1a008524268)</span></li>
<li>lib/logmanager_dummy.cpp <span style="color: grey">(bf1180905dec72faf116ee8f1175067b16dd207e)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(d01d7e16b79032efd3cbd98b4ffaa89fc2267067)</span></li>
<li>logviewer/conversation-date-picker.h <span style="color: grey">(d39e68d8e99809c5f00a69d1e51010612341b7b9)</span></li>
<li>logviewer/conversation-date-picker.cpp <span style="color: grey">(c3c31eca666227e9bd7d856b4a0aaafb3d7782d5)</span></li>
<li>logviewer/entity-model-item.h <span style="color: grey">(87139567f319e9dc73c7384db035f4e756ab3075)</span></li>
<li>logviewer/entity-model-item.cpp <span style="color: grey">(b5ace64631d985e9edcd120c4435e575c4fa7874)</span></li>
<li>logviewer/entity-model.h <span style="color: grey">(37cdeae3e884e93026bc29a80795edb109f01047)</span></li>
<li>logviewer/entity-model.cpp <span style="color: grey">(4f0dc496896858dfb9f1aef4cb8ec1f46bacd125)</span></li>
<li>logviewer/entity-proxy-model.h <span style="color: grey">(78dd07190c9c2d3de37a60e0aca8f5f9d825713c)</span></li>
<li>logviewer/entity-proxy-model.cpp <span style="color: grey">(e8c440ea900fd605064ad259201b60afed51f2a0)</span></li>
<li>logviewer/entity-view.cpp <span style="color: grey">(97e7087a8e98348db7ed4ddd13becf895ce8623e)</span></li>
<li>logviewer/log-viewer.h <span style="color: grey">(f5f512ffada33bffb39763c3efc569551d41d17b)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(6fca33d6d9319a1f2a8f3aafe8ac47624de436c3)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(be894c52fcbbcc3feb1c503485518dbcd3aae1f5)</span></li>
<li>logviewer/message-view.h <span style="color: grey">(4dcf49cb851714a6279eebd4443bac089aca8ec8)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(13a67d9d55c76ab4b4df12d6a435a9edee440e32)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112006/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>