Review Request 112097: Add custom status to plasmoid context menu in systray

[Siddhartha Sahu]

> On Aug. 15, 2013, 12:12 p.m., David Edmundson wrote:
> > Looks pretty damn good.

Thank you :)


> On Aug. 15, 2013, 12:12 p.m., David Edmundson wrote:
> > presence/src/presence-applet.cpp, line 165
> > <http://git.reviewboard.kde.org/r/112097/diff/1/?file=179726#file179726line165>
> >
> >     just m_presences.append(presence) will do?

appending will not sort the statuses by type?


> On Aug. 15, 2013, 12:12 p.m., David Edmundson wrote:
> > presence/src/presence-applet.cpp, line 164
> > <http://git.reviewboard.kde.org/r/112097/diff/1/?file=179726#file179726line164>
> >
> >     You cast from a KTp::Presence to a KTp::Presence?

I copied it from the globalpresencechooser.cpp :D
I do not have an indepth idea of how this is working.


> On Aug. 15, 2013, 12:12 p.m., David Edmundson wrote:
> > presence/src/presence-applet.h, line 33
> > <http://git.reviewboard.kde.org/r/112097/diff/1/?file=179725#file179725line33>
> >
> >     Where is this used?

I think this is not used anymore (remnant from a previous iteration)


- Siddhartha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112097/#review37836
-----------------------------------------------------------


On Aug. 15, 2013, 12:05 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112097/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 12:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds stored custom status to the context menu in telepathy presence plasmoid in systray. 
> 
> 
> This addresses bug 317550.
>     http://bugs.kde.org/show_bug.cgi?id=317550
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.h 95b3f18 
>   presence/src/presence-applet.cpp fe1452c 
> 
> Diff: http://git.reviewboard.kde.org/r/112097/diff/
> 
> 
> Testing
> -------
> 
> I have compiled and installed telepathy-kde from master and have tested the changes on my laptop. All different types of custom messages that I have set previously are present as as menu option, and selecting one of them successfully sets the corresponding status.
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130815/93339771/attachment-0001.html>