Review Request 112097: Add custom status to plasmoid context menu in systray

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112097/#review37836
-----------------------------------------------------------


Looks pretty damn good.


presence/src/presence-applet.h
<http://git.reviewboard.kde.org/r/112097/#comment28005>

    Where is this used?



presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/112097/#comment28007>

    You cast from a KTp::Presence to a KTp::Presence?



presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/112097/#comment28006>

    just m_presences.append(presence) will do?



presence/src/presence-applet.cpp
<http://git.reviewboard.kde.org/r/112097/#comment28008>

    could you check entry.size() == 2
    
    Otherwise we crash on bad data. This is a real problem here because we would crash all of plasma.


- David Edmundson


On Aug. 15, 2013, 12:05 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112097/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 12:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds stored custom status to the context menu in telepathy presence plasmoid in systray. 
> 
> 
> This addresses bug 317550.
>     http://bugs.kde.org/show_bug.cgi?id=317550
> 
> 
> Diffs
> -----
> 
>   presence/src/presence-applet.h 95b3f18 
>   presence/src/presence-applet.cpp fe1452c 
> 
> Diff: http://git.reviewboard.kde.org/r/112097/diff/
> 
> 
> Testing
> -------
> 
> I have compiled and installed telepathy-kde from master and have tested the changes on my laptop. All different types of custom messages that I have set previously are present as as menu option, and selecting one of them successfully sets the corresponding status.
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130815/793e09ab/attachment.html>