Review Request 111965: Only fetch RosterGropus in GlobalContactManager if supported

[David Edmundson]

> On Aug. 10, 2013, 2:58 p.m., Dan Vrátil wrote:
> > Adding the feature to Tp::Features if the iface is available might be simpler (codewise), but this works fine.
> > 
> > Tp::Features features;
> > features << Tp::FeatureRoster;
> > if (connection->hasInterface(....) {
> >   features << Tp::FeatureRosterGroups;
> > }
> > connection->becomeReady(features);
> > 
> >

I agree. I thought that after I did my patch, but then was too lazy/excited to do it.
I'm glad you're making me change it :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111965/#review37465
-----------------------------------------------------------


On Aug. 9, 2013, 1:15 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111965/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 1:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Only fetch RosterGropus in GlobalContactManager if supported
> 
> 
> Diffs
> -----
> 
>   KTp/global-contact-manager.cpp f8be0b5a9671b83596e35c6a2028187d75eb2109 
> 
> Diff: http://git.reviewboard.kde.org/r/111965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130810/e8b6ea0b/attachment.html>