Review Request 111965: Only fetch RosterGropus in GlobalContactManager if supported

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111965/#review37465
-----------------------------------------------------------

Ship it!


Adding the feature to Tp::Features if the iface is available might be simpler (codewise), but this works fine.

Tp::Features features;
features << Tp::FeatureRoster;
if (connection->hasInterface(....) {
  features << Tp::FeatureRosterGroups;
}
connection->becomeReady(features);




KTp/global-contact-manager.cpp
<http://git.reviewboard.kde.org/r/111965/#comment27706>

    Add spaces around "+"


- Dan Vrátil


On Aug. 9, 2013, 3:15 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111965/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 3:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Only fetch RosterGropus in GlobalContactManager if supported
> 
> 
> Diffs
> -----
> 
>   KTp/global-contact-manager.cpp f8be0b5a9671b83596e35c6a2028187d75eb2109 
> 
> Diff: http://git.reviewboard.kde.org/r/111965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130810/17703c08/attachment.html>