Review Request 110228: [ktp-kded-module] Now playing shouldn't be disabled on pause

[Ian Monroe]

> On April 28, 2013, 9:15 p.m., David Edmundson wrote:
> > telepathy-mpris.cpp, line 222
> > <http://git.reviewboard.kde.org/r/110228/diff/3/?file=141297#file141297line222>
> >
> >     I don't think this is right. I believe this config setting is part of the config module that allows you to turn on whether now playing works or not.
> >     
> >     Though I think it sort of ties in with https://bugs.kde.org/show_bug.cgi?id=307582 which states that this entire config option is weird and pointless.
> >     
> >     I need Martin to confirm.

So basically:

* enabled: the user has, in this session, picked the 'now playing' status
* active: IFF enabled and there's a MPRIS player actively playing something. TelepathyMPRIS is setting the status string.
* nowPlayingEnabled setting in ktelepathyrc: If enabled, don't show the message box when the user picks the now playing status. Has no other effect. So a better name would be something like "showNowPlayingMessageBox" with the logic reversed. 

If Martin agrees with that spec, I'll finish the patch accordingly.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110228/#review31706
-----------------------------------------------------------


On April 28, 2013, 5:14 a.m., Ian Monroe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110228/
> -----------------------------------------------------------
> 
> (Updated April 28, 2013, 5:14 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> Now playing shouldn't be disabled on pause
>     
> requires a corresponding commit in ktp-contact-list https://git.reviewboard.kde.org/r/110227/
> 
> Also initialized the pointers
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp c7a01b557952c35df3b547e44ddc851abec2f59b 
>   telepathy-mpris.cpp 7a06e6bde96a51151dae3b68933749fa3a6fb574 
> 
> Diff: http://git.reviewboard.kde.org/r/110228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Monroe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130429/31d63a31/attachment-0001.html>