Review Request 110228: [ktp-kded-module] Now playing shouldn't be disabled on pause

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110228/#review31706
-----------------------------------------------------------



telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/110228/#comment23624>

    coding style in KTp requires braces {}
    
    (we use the same as kdelibs)



telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/110228/#comment23627>

    I don't think this is right. I believe this config setting is part of the config module that allows you to turn on whether now playing works or not.
    
    Though I think it sort of ties in with https://bugs.kde.org/show_bug.cgi?id=307582 which states that this entire config option is weird and pointless.
    
    I need Martin to confirm.


- David Edmundson


On April 28, 2013, 5:14 a.m., Ian Monroe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110228/
> -----------------------------------------------------------
> 
> (Updated April 28, 2013, 5:14 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> Now playing shouldn't be disabled on pause
>     
> requires a corresponding commit in ktp-contact-list https://git.reviewboard.kde.org/r/110227/
> 
> Also initialized the pointers
> 
> 
> Diffs
> -----
> 
>   telepathy-module.cpp c7a01b557952c35df3b547e44ddc851abec2f59b 
>   telepathy-mpris.cpp 7a06e6bde96a51151dae3b68933749fa3a6fb574 
> 
> Diff: http://git.reviewboard.kde.org/r/110228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Monroe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130428/4ad5b0b4/attachment.html>