Review Request 110028: Make sure to supress any remaining connection cancelled messages

Commit Hook null at kde.org
Tue Apr 16 10:18:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110028/#review31144
-----------------------------------------------------------


This review has been submitted with commit 68e2e30e9820d0b6fe146e1dceb9313e7a3f968c by David Edmundson to branch kde-telepathy-0.6.

- Commit Hook


On April 15, 2013, 3:26 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110028/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 3:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Make sure to supress any remaining connection cancelled messages
> 
> If authentication fails becomes the user cancels or because the password is wrong
> the connection still has the same ConnectionStatusReason
> 
> We want to supress user cancelled auth so we check the connectionError string which
> is more detailed and gives the reason the auth failed
> 
> This is for the 0.6 branch.
> 
> 
> Diffs
> -----
> 
>   error-handler.cpp 7149f750a92728f1bc763709623f6aacce8b96b8 
> 
> Diff: http://git.reviewboard.kde.org/r/110028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130416/f33a8592/attachment-0001.html>


More information about the KDE-Telepathy mailing list