Review Request 110028: Make sure to supress any remaining connection cancelled messages

[David Edmundson]

> On April 16, 2013, 5:22 a.m., Martin Klapetek wrote:
> > error-handler.cpp, line 140
> > <http://git.reviewboard.kde.org/r/110028/diff/1/?file=138971#file138971line140>
> >
> >     The switch here is useless (has only one case) and makes the code very confusing (are the breaks below breaking the switch or the while...?), I'd like to see this rewritten eventually

OK.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110028/#review31135
-----------------------------------------------------------


On April 15, 2013, 3:26 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110028/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 3:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Make sure to supress any remaining connection cancelled messages
> 
> If authentication fails becomes the user cancels or because the password is wrong
> the connection still has the same ConnectionStatusReason
> 
> We want to supress user cancelled auth so we check the connectionError string which
> is more detailed and gives the reason the auth failed
> 
> This is for the 0.6 branch.
> 
> 
> Diffs
> -----
> 
>   error-handler.cpp 7149f750a92728f1bc763709623f6aacce8b96b8 
> 
> Diff: http://git.reviewboard.kde.org/r/110028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130416/1ed74be0/attachment.html>