Review Request 110004: Loose the word "tube" in approver; use just one notification for unknown tube

[Daniele E. Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110004/#review31034
-----------------------------------------------------------


Sorry if I'm late and it was already committed, but I have a comment...


src/tubechannelapprover.cpp
<http://git.reviewboard.kde.org/r/110004/#comment23085>

    Perhaps the notification should display serviceName as well, so that even if you have a service that don't install a .desktop file, you can still see its name.
    Here "unknown service" means "a tube with a service name that is unknown to the approver", but the user might know what the service name means, so I believe it's worth displaying it.


- Daniele E. Domenichelli


On April 14, 2013, 5:54 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110004/
> -----------------------------------------------------------
> 
> (Updated April 14, 2013, 5:54 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> If I understand the original code correctly - if there are no services found, it shows "unknown tube" notification. If there are services but none for the given tube, it shows "user wants to start a remote service" notification, but these cases are the same - ie. no service found for the given tube, so let's simplify the logic and loose the word "tube".
> 
> 
> Diffs
> -----
> 
>   src/tubechannelapprover.cpp cc651e0 
> 
> Diff: http://git.reviewboard.kde.org/r/110004/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130414/cc9fa6fc/attachment.html>