Review Request 110004: Loose the word "tube" in approver; use just one notification for unknown tube

Commit Hook null at kde.org
Sun Apr 14 05:54:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110004/
-----------------------------------------------------------

(Updated April 14, 2013, 5:54 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

If I understand the original code correctly - if there are no services found, it shows "unknown tube" notification. If there are services but none for the given tube, it shows "user wants to start a remote service" notification, but these cases are the same - ie. no service found for the given tube, so let's simplify the logic and loose the word "tube".


Diffs
-----

  src/tubechannelapprover.cpp cc651e0 

Diff: http://git.reviewboard.kde.org/r/110004/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130414/6c18a485/attachment.html>


More information about the KDE-Telepathy mailing list