Review Request 109556: Remove KMessageWidget from ContactInfoDialog
Commit Hook
null at kde.org
Mon Apr 1 17:37:18 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109556/
-----------------------------------------------------------
(Updated April 1, 2013, 5:37 p.m.)
Status
------
This change has been marked as submitted.
Review request for Telepathy.
Description
-------
Remove KMessageWidget from ContactInfoDialog
It is perfectly valid for upgradeContact() to fail if FeatureInfo is missing
Also we should NEVER show Tp::PendingOperation error messages to the user
Additional comment, this file should be in widgets, should I move it?
Diffs
-----
KTp/contact-info-dialog.cpp 17ad58390ec356beb04925d2899c3be83b8cf038
Diff: http://git.reviewboard.kde.org/r/109556/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130401/f7f05416/attachment.html>
More information about the KDE-Telepathy
mailing list