Review Request 109556: Remove KMessageWidget from ContactInfoDialog

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109556/#review30220
-----------------------------------------------------------


This review has been submitted with commit 77b4a75c0054c2aa9de87c06eeef1922ca976084 by David Edmundson to branch kde-telepathy-0.6.

- Commit Hook


On March 18, 2013, 1:47 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109556/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 1:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove KMessageWidget from ContactInfoDialog
> 
> It is perfectly valid for upgradeContact() to fail if FeatureInfo is missing
> Also we should NEVER show Tp::PendingOperation error messages to the user
> 
> 
> Additional comment, this file should be in widgets, should I move it?
> 
> 
> Diffs
> -----
> 
>   KTp/contact-info-dialog.cpp 17ad58390ec356beb04925d2899c3be83b8cf038 
> 
> Diff: http://git.reviewboard.kde.org/r/109556/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130401/eb481e7d/attachment.html>