Review Request: Fix a bug in which the PendingWallet would hang forever if the wallet system is disabled

David Edmundson kde at davidedmundson.co.uk
Mon Sep 24 22:29:45 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106560/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Fix a bug in which the PendingWallet would hang forever if the wallet system is disabled

This fixes bugs in the auth handler and AccountsKCM

BUG: 307237 (auth handler blocks and does nothing)
BUG: 307302 (accounts KCM crashes)
BUG: 306953 (accounts KCM crashes)


Diffs
-----

  KTp/Models/CMakeLists.txt e6a65b4e66902eb759352cd225fe67053e8a766d 
  KTp/Models/rooms-model.h PRE-CREATION 
  KTp/Models/rooms-model.cpp PRE-CREATION 
  KTp/Widgets/CMakeLists.txt 0dcf7c13ef7013afb94e3685f1925d59bece1833 
  KTp/Widgets/join-chat-room-dialog.h PRE-CREATION 
  KTp/Widgets/join-chat-room-dialog.cpp PRE-CREATION 
  KTp/Widgets/join-chat-room-dialog.ui PRE-CREATION 
  KTp/pending-wallet.cpp c8680b97be5a40abf4fc310b614c772804a66c39 
  data/ktelepathy.notifyrc 0e0394dd78f95b5feca00681beb5e32bec41a318 

Diff: http://git.reviewboard.kde.org/r/106560/diff/


Testing
-------

Disabled wallet system (before applying patch). Confirmed no widgets appeared
Applied this patch, everything now works (except password not being saved) 


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120924/7b91a0ec/attachment.html>


More information about the KDE-Telepathy mailing list