Review Request: Fix formatting plugin

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Fri Sep 21 07:44:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106005/
-----------------------------------------------------------

(Updated Sept. 21, 2012, 7:44 a.m.)


Review request for Telepathy, David Edmundson and Lasath Fernando.


Changes
-------

Fixed issues reported by David, and changed author to "KDE Telepathy Developers"

QLatin1String in "tagsMap[QLatin1String("_")] = QLatin1Char('u')" cannot be changed to QLatin1String, unless I change it to "QString(QLatin1Char('*'))" or something similar, I'm not sure if it is worth. All the others were changed...


Description
-------

Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin


Diffs (updated)
-----

  filters/CMakeLists.txt db5cffeb5918c6273086905b1691a2ed15a58cbc 
  filters/formatting/format-filter.h 4980aff8251a91b2e23de2a7d8257ed25b5d1322 
  filters/formatting/format-filter.cpp 75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1 
  filters/formatting/ktptextui_message_filter_formatting.desktop d43edf8722e18fb104e774ac158c76732e9173a4 
  tests/message-processor-basic-tests.h 5ffcc92864820d9fd8c535cd4e249cb31310011b 
  tests/message-processor-basic-tests.cpp a404908152ef9e21eb7e98cb472775f78c8a4162 

Diff: http://git.reviewboard.kde.org/r/106005/diff/


Testing
-------

Unit tests included and a few more visual test


Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120921/5341b9ef/attachment-0001.html>


More information about the KDE-Telepathy mailing list