Review Request: Fix formatting plugin

[David Edmundson]

> On Sept. 19, 2012, 8:06 a.m., David Edmundson wrote:
> > filters/formatting/ktptextui_message_filter_formatting.desktop, line 3
> > <http://git.reviewboard.kde.org/r/106005/diff/3/?file=86243#file86243line3>
> >
> >     Not sure about the new name (though it's better).
> >     "Plain text formatting" doesn't imply it makes it non plain-text at the end.
> >     
> >     Ping me on IRC, lets brainstorm a few ideas / you can convince me this is best.

Documenting the discussion on IRC.

I proposed the name "Text Formatting".  DrDanz was ok with this.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106005/#review19141
-----------------------------------------------------------


On Sept. 19, 2012, 7:35 a.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106005/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 7:35 a.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Lasath Fernando.
> 
> 
> Description
> -------
> 
> Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin
> 
> 
> Diffs
> -----
> 
>   tests/message-processor-basic-tests.h 5ffcc92864820d9fd8c535cd4e249cb31310011b 
>   tests/message-processor-basic-tests.cpp a404908152ef9e21eb7e98cb472775f78c8a4162 
>   filters/CMakeLists.txt db5cffeb5918c6273086905b1691a2ed15a58cbc 
>   filters/formatting/format-filter.h 4980aff8251a91b2e23de2a7d8257ed25b5d1322 
>   filters/formatting/format-filter.cpp 75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1 
>   filters/formatting/ktptextui_message_filter_formatting.desktop d43edf8722e18fb104e774ac158c76732e9173a4 
> 
> Diff: http://git.reviewboard.kde.org/r/106005/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included and a few more visual test
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120920/35609f91/attachment.html>