Review Request: Rename AccountsModel to ContactsModel as it is a model of contacts.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106432/#review18925
-----------------------------------------------------------


Since you are renaming AccountsModel, perhaps you should rename AccountsFilterModel as well?
Anyway as I told on IRC I don't like the new name, but if you feel that it is ok then ship it


KTp/Models/contacts-model.h
<http://git.reviewboard.kde.org/r/106432/#comment15003>

    Update the header guards as well...


Please update all the modules using it when you push it, or we will have peoples complaining on irc

- Daniele Elmo Domenichelli


On Sept. 12, 2012, 3:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106432/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 3:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Rename AccountsModel to ContactsModel as it is a model of contacts.
> 
> This is in preperation for providing a model of accounts to use in combo boxes everywhere. (this will be called AccountsModel, and would be very confusing if we don't rename this)
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt e6a65b4e66902eb759352cd225fe67053e8a766d 
>   KTp/Models/accounts-filter-model.cpp 607df5492cacf96ca1f125760f51d5d900094e5e 
>   KTp/Models/accounts-model-item.cpp 12794178becf0fee635511b39d3a08726e75b64f 
>   KTp/Models/accounts-model.h caf93faa1aa95308d722a73accea0205abc8a6b8 
>   KTp/Models/accounts-model.cpp 8233a37f62808a7ba58bfcb4471bf734ad813a93 
>   KTp/Models/contact-model-item.cpp 1bf32d730ff4e6b3179f3342b30d9dca5e108553 
>   KTp/Models/contacts-model.h PRE-CREATION 
>   KTp/Models/contacts-model.cpp PRE-CREATION 
>   KTp/Models/groups-model-item.cpp c85ffbf6e5f30f36f006ec097743397cbfd8e2c5 
>   KTp/Models/groups-model.h 00e6f1a943b17dd07e54c30613e3566ba271aace 
>   KTp/Models/groups-model.cpp f0d607d2d13261f75158a26ebe274170062db2c4 
>   KTp/Models/proxy-tree-node.cpp fb5674bddffc5cc5d3c07662a5466d99f6b79fbb 
>   KTp/Widgets/add-contact-dialog.h a32633b6a86e2aefc728ed4b7b511de0c3e8d733 
>   KTp/Widgets/add-contact-dialog.cpp 7198c126df8354bbfa5df3bdf0020e1e8cf8b4cb 
>   KTp/Widgets/contact-grid-dialog.h 2df1c21b2983643922645a1c5efddd6dfe7ae198 
>   KTp/Widgets/contact-grid-dialog.cpp 56222410f10060fc4035d60e3e8219494b3d528d 
>   KTp/Widgets/contact-grid-widget.h 256a09a7589d26bad2ec2e225777240993a2c67f 
>   KTp/Widgets/contact-grid-widget.cpp eb25d7e64df9979d9922a03750155af8432de570 
> 
> Diff: http://git.reviewboard.kde.org/r/106432/diff/
> 
> 
> Testing
> -------
> 
> Updated ContactList to the rename. Everything still works.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120913/603494e4/attachment-0001.html>