<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106432/">http://git.reviewboard.kde.org/r/106432/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since you are renaming AccountsModel, perhaps you should rename AccountsFilterModel as well?
Anyway as I told on IRC I don't like the new name, but if you feel that it is ok then ship it</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106432/diff/1/?file=85131#file85131line23" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Models/contacts-model.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef TELEPATHY_ACCOUNTS_MODEL_H</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#define TELEPATHY_ACCOUNTS_MODEL_H</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update the header guards as well...</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please update all the modules using it when you push it, or we will have peoples complaining on irc</pre>
<p>- Daniele Elmo</p>
<br />
<p>On September 12th, 2012, 3:38 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2012, 3:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename AccountsModel to ContactsModel as it is a model of contacts.
This is in preperation for providing a model of accounts to use in combo boxes everywhere. (this will be called AccountsModel, and would be very confusing if we don't rename this)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated ContactList to the rename. Everything still works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/CMakeLists.txt <span style="color: grey">(e6a65b4e66902eb759352cd225fe67053e8a766d)</span></li>
<li>KTp/Models/accounts-filter-model.cpp <span style="color: grey">(607df5492cacf96ca1f125760f51d5d900094e5e)</span></li>
<li>KTp/Models/accounts-model-item.cpp <span style="color: grey">(12794178becf0fee635511b39d3a08726e75b64f)</span></li>
<li>KTp/Models/accounts-model.h <span style="color: grey">(caf93faa1aa95308d722a73accea0205abc8a6b8)</span></li>
<li>KTp/Models/accounts-model.cpp <span style="color: grey">(8233a37f62808a7ba58bfcb4471bf734ad813a93)</span></li>
<li>KTp/Models/contact-model-item.cpp <span style="color: grey">(1bf32d730ff4e6b3179f3342b30d9dca5e108553)</span></li>
<li>KTp/Models/contacts-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/contacts-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/groups-model-item.cpp <span style="color: grey">(c85ffbf6e5f30f36f006ec097743397cbfd8e2c5)</span></li>
<li>KTp/Models/groups-model.h <span style="color: grey">(00e6f1a943b17dd07e54c30613e3566ba271aace)</span></li>
<li>KTp/Models/groups-model.cpp <span style="color: grey">(f0d607d2d13261f75158a26ebe274170062db2c4)</span></li>
<li>KTp/Models/proxy-tree-node.cpp <span style="color: grey">(fb5674bddffc5cc5d3c07662a5466d99f6b79fbb)</span></li>
<li>KTp/Widgets/add-contact-dialog.h <span style="color: grey">(a32633b6a86e2aefc728ed4b7b511de0c3e8d733)</span></li>
<li>KTp/Widgets/add-contact-dialog.cpp <span style="color: grey">(7198c126df8354bbfa5df3bdf0020e1e8cf8b4cb)</span></li>
<li>KTp/Widgets/contact-grid-dialog.h <span style="color: grey">(2df1c21b2983643922645a1c5efddd6dfe7ae198)</span></li>
<li>KTp/Widgets/contact-grid-dialog.cpp <span style="color: grey">(56222410f10060fc4035d60e3e8219494b3d528d)</span></li>
<li>KTp/Widgets/contact-grid-widget.h <span style="color: grey">(256a09a7589d26bad2ec2e225777240993a2c67f)</span></li>
<li>KTp/Widgets/contact-grid-widget.cpp <span style="color: grey">(eb25d7e64df9979d9922a03750155af8432de570)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106432/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>