Review Request: Make default presence variants not bold, use italic font to visually distinguish special presence variants.

[Heiko Tietze]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105348/#review18745
-----------------------------------------------------------

Ship it!


Changing default font is a good idea when applied to different categories or the like. But the contact list consists of equal entries. So normal font should be applied as proposed.

- Heiko Tietze


On June 25, 2012, 7:50 p.m., Nikita Skovoroda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105348/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 7:50 p.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> The bold font looks bad, especially if there is no custom presences (then almost all variants are bold).
> 
> Changes done by the patch:
> 1) global-presence-chooser.cpp — make special presences italic.
> 2) presence-model.cpp — make presences without status message not bold.
> 3) presence-model.cpp — make presences with status message italic.
> 
> This replaces «normal» font with «italic», and «bold» with «normal» in the presence shooser.
> 
> Looks better to me.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 6729f51 
>   presence-model.cpp 72bfc3d 
> 
> Diff: http://git.reviewboard.kde.org/r/105348/diff/
> 
> 
> Testing
> -------
> 
> Does not break anything. The result is on the screenshots.
> 
> This does not break visual separation of different status groups, when there are a lot of custom presences (the bold entries separated them) — they can be easily distingushed thanks to the icons.
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/105348/s/608/
> After
>   http://git.reviewboard.kde.org/r/105348/s/609/
> 
> 
> Thanks,
> 
> Nikita Skovoroda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120909/792e3e9e/attachment.html>