<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105348/">http://git.reviewboard.kde.org/r/105348/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changing default font is a good idea when applied to different categories or the like. But the contact list consists of equal entries. So normal font should be applied as proposed.</pre>
<br />
<p>- Heiko</p>
<br />
<p>On June 25th, 2012, 7:50 p.m., Nikita Skovoroda wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and KDE Usability.</div>
<div>By Nikita Skovoroda.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 7:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bold font looks bad, especially if there is no custom presences (then almost all variants are bold).
Changes done by the patch:
1) global-presence-chooser.cpp — make special presences italic.
2) presence-model.cpp — make presences without status message not bold.
3) presence-model.cpp — make presences with status message italic.
This replaces «normal» font with «italic», and «bold» with «normal» in the presence shooser.
Looks better to me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does not break anything. The result is on the screenshots.
This does not break visual separation of different status groups, when there are a lot of custom presences (the bold entries separated them) — they can be easily distingushed thanks to the icons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>global-presence-chooser.cpp <span style="color: grey">(6729f51)</span></li>
<li>presence-model.cpp <span style="color: grey">(72bfc3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105348/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105348/s/608/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/25/180_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/105348/s/609/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/25/179_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>