Review Request: Code tidy of contact-request-handler

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106298/#review18427
-----------------------------------------------------------

Ship it!


Thanks for taking this. I'd like to get this into 0.5.1, except the strings of course. Some strings suggestions below, I think we can do even more better with the rest.


contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/106298/#comment14548>

    Let's rephrase this - "Error while granting contact authorization" and remove the second string altogether and leave only the error. Thoughts?



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/106298/#comment14545>

    I'd propose more friendlier string (what is "contact request"?) like - "%1 contact/s want/s to add you to their contact list" or something.


- Martin Klapetek


On Sept. 1, 2012, 6:20 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106298/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 6:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove status notifier item when all contacts have been processed
> 
> Tidied some of the surrounding code.
> Removed completely pointless member variable.
> Added guards round all usagse of QWeakPointer::data()
> 
> BUG: 302471
> 
> Pass Contact property to onFinalizeSubscriptionFinished from onAuthorizePresencePublicationFinished
> 
> BUG: 305706
> 
> 
> Update strings to be more user friendly
> 
> 
> Diffs
> -----
> 
>   contact-request-handler.h 45bbd8d29803476d8dee9a753faada362c02e869 
>   contact-request-handler.cpp 542e65b10bcc33f5abc2643986d2093c46ea87af 
> 
> Diff: http://git.reviewboard.kde.org/r/106298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120902/c883cc5a/attachment-0001.html>