Review Request: Code tidy of contact-request-handler

David Edmundson kde at davidedmundson.co.uk
Sat Sep 1 06:20:23 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106298/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Remove status notifier item when all contacts have been processed

Tidied some of the surrounding code.
Removed completely pointless member variable.
Added guards round all usagse of QWeakPointer::data()

BUG: 302471

Pass Contact property to onFinalizeSubscriptionFinished from onAuthorizePresencePublicationFinished

BUG: 305706


Update strings to be more user friendly


Diffs
-----

  contact-request-handler.h 45bbd8d29803476d8dee9a753faada362c02e869 
  contact-request-handler.cpp 542e65b10bcc33f5abc2643986d2093c46ea87af 

Diff: http://git.reviewboard.kde.org/r/106298/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120901/61e9d9ae/attachment.html>


More information about the KDE-Telepathy mailing list