Review Request: Display avatars in logs and more details in header

[Dan Vratil]

> On Sept. 1, 2012, 4:48 a.m., David Edmundson wrote:
> > logviewer/message-view.cpp, line 60
> > <http://git.reviewboard.kde.org/r/106296/diff/2/?file=82594#file82594line60>
> >
> >     Wasn't there a crash last week when account was null?
> >     
> >     If so, check isNull before doing stuff like this :)

You can get null account from Tpl::SearchHit, but the account passed to MessageView is obtained from the EntityModel, which guarantees that it won't be null (the item wouldn't be displayed otherwise). So the only place where to worry about null accounts is in the filter-related code. 


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106296/#review18355
-----------------------------------------------------------


On Sept. 1, 2012, 1:05 a.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106296/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 1:05 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> - use nice user name in log header instead of account name
> - initialize conversation start time
> - display avatars
> 
> The avatars only work in single-user chats. The current default MUC theme does not support avatars anyway and Tpl::Event::sender() provides only avatar token so we have to obtain filename of cached avatar from Tp::Contact representing the channel.
> 
> 
> Diffs
> -----
> 
>   logviewer/log-viewer.cpp 83d329c 
>   logviewer/message-view.h 40c281b 
>   logviewer/message-view.cpp b94f58f 
> 
> Diff: http://git.reviewboard.kde.org/r/106296/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120901/26f90ec4/attachment.html>