Review Request: Display avatars in logs and more details in header

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106296/#review18355
-----------------------------------------------------------

Ship it!


Lots of potential crashing points, given the null pointers we have going on in the log viewer.


logviewer/message-view.cpp
<http://git.reviewboard.kde.org/r/106296/#comment14496>

    Wasn't there a crash last week when account was null?
    
    If so, check isNull before doing stuff like this :)



logviewer/message-view.cpp
<http://git.reviewboard.kde.org/r/106296/#comment14499>

    m_contact can be null, don't crash :)



logviewer/message-view.cpp
<http://git.reviewboard.kde.org/r/106296/#comment14498>

    again, can account can be null?



logviewer/message-view.cpp
<http://git.reviewboard.kde.org/r/106296/#comment14497>

    m_contact can definitely be null, such as if your account is offline.


- David Edmundson


On Sept. 1, 2012, 1:05 a.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106296/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 1:05 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> - use nice user name in log header instead of account name
> - initialize conversation start time
> - display avatars
> 
> The avatars only work in single-user chats. The current default MUC theme does not support avatars anyway and Tpl::Event::sender() provides only avatar token so we have to obtain filename of cached avatar from Tp::Contact representing the channel.
> 
> 
> Diffs
> -----
> 
>   logviewer/log-viewer.cpp 83d329c 
>   logviewer/message-view.h 40c281b 
>   logviewer/message-view.cpp b94f58f 
> 
> Diff: http://git.reviewboard.kde.org/r/106296/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120901/d555d6e6/attachment-0001.html>