Review Request: Install TelepathyLoggerQt4Config.cmake and export files
Daniele Elmo Domenichelli
daniele.domenichelli at gmail.com
Tue Oct 30 00:49:42 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107119/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
Update build system to use latest tools and cmake stuff from tp-qt 0.9.3 and install TelepathyLoggerQt4Config.cmake and export files.
This allows to remove the FindTelepathyLoggerQt4.cmake files and to check for its version
Note: most of the changes are files just copied from tp-qt 0.9.3. The relevant files are:
- CMakeLists.txt
- TelepathyLoggerQt4/CMakeLists.txt
- TelepathyLoggerQt4/TelepathyLoggerQt4Config.cmake.in
This addresses bug 304856.
http://bugs.kde.org/show_bug.cgi?id=304856
Diffs
-----
tools/qt4-types-gen.py 1a5fef7b28937a4a364ce6895858c465c08455ff
tools/qt4-client-gen.py 22223946256af4d9f8ba0040de44a92b4ae3da96
tools/qt4-constants-gen.py 11c4b5eda1843fe9eccb599ca3bb939106478ec9
tools/qt-types-gen.py PRE-CREATION
tools/qt-svc-gen.py PRE-CREATION
tools/qt-constants-gen.py PRE-CREATION
tools/qt-client-gen.py PRE-CREATION
tools/libqtcodegen.py PRE-CREATION
tools/CMakeLists.txt 36d70a0b655f6333bbfd2a7d18b805711a2ea1f1
tools/libqt4codegen.py 8cf1889808f79fb0f9c2ccfa7b7194937a55fd2d
cmake/modules/TpQtMacros.cmake PRE-CREATION
cmake/modules/MacroWriteBasicCMakeVersionFile.cmake PRE-CREATION
cmake/modules/TpQt4Macros.cmake 85fb925be3fc4c1ded41fd65acd7286eca97d82c
TelepathyLoggerQt4/CMakeLists.txt ae688d3a0a95203a4fc7b51ffbbf02d06a7d7592
TelepathyLoggerQt4/TelepathyLoggerQt4Config.cmake.in PRE-CREATION
cmake/modules/BasicFindPackageVersion.cmake.in PRE-CREATION
cmake/modules/FindQt.cmake PRE-CREATION
cmake/modules/FindQt5.cmake PRE-CREATION
CMakeLists.txt b88e06e2a28d77400bfa5480e02cfdce34482891
tools/tp-qt-tests.supp PRE-CREATION
tools/tp-qt4-tests.supp 2c0f12011d2d356416e2ab8f146eab0d738f1668
Diff: http://git.reviewboard.kde.org/r/107119/diff/
Testing
-------
Built and tested text-ui and log-viewer after removing FindTelepathyLogger.cmake and FindTelepathyLoggerQt4.cmake
Version check works
- macro_optional_find_package(TelepathyLoggerQt4 0.5.1) -> found
- macro_optional_find_package(TelepathyLoggerQt4 0.5.2) -> not found
Thanks,
Daniele Elmo Domenichelli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121030/7b1824b2/attachment.html>
More information about the KDE-Telepathy
mailing list