Review Request: Implement channel password handling

[Rohan Garg]

> On Oct. 28, 2012, 9:58 a.m., David Edmundson wrote:
> > conferenceauth-observer.cpp, line 56
> > <http://git.reviewboard.kde.org/r/107089/diff/1/?file=92621#file92621line56>
> >
> >     Don't do this.
> >     
> >     Instead
> >     
> >     foreach (Tp::ChannelPtr channels) {
> >       if (channel->hasInterface(...)  {
> >          doStuff();
> >        }
> >     }
> >     
> >     I don't fully understand when you get two channels at once, but I think it is possible. Otherwise it wouldn't be a list in the first place

Yeah, already in progress, saw it right after I posted the review.
As for multiple channels, I /think/ this might be a usecase when I implement auto-joining channels and alot of the channels have a password interface


> On Oct. 28, 2012, 9:58 a.m., David Edmundson wrote:
> > CMakeLists.txt, line 42
> > <http://git.reviewboard.kde.org/r/107089/diff/1/?file=92618#file92618line42>
> >
> >     rename-like-the-others

Righto


> On Oct. 28, 2012, 9:58 a.m., David Edmundson wrote:
> > conferenceauth-observer.cpp, line 82
> > <http://git.reviewboard.kde.org/r/107089/diff/1/?file=92621#file92621line82>
> >
> >     I don't see why we need to wait until the passwordOp is ready order to complete the methodInvocationContext.
> >     
> >     I /think/ this can be moved into the observeChannels which will make launching channels quicker. I may be wrong though.
> >     
> >     
> >

Will fix this once I test this out.


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107089/#review21033
-----------------------------------------------------------


On Oct. 28, 2012, 9:41 a.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107089/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2012, 9:41 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implement password handling for channels that have a password interface
> 
> 
> This addresses bug 288502.
>     http://bugs.kde.org/show_bug.cgi?id=288502
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 09ffb1b06723ce65f3d9893ecfb850e5d8191796 
>   KTp.ConfAuthObserver.client PRE-CREATION 
>   conferenceauth-observer.h PRE-CREATION 
>   conferenceauth-observer.cpp PRE-CREATION 
>   conferenceauthop.h PRE-CREATION 
>   conferenceauthop.cpp PRE-CREATION 
>   main.cpp d77d800a06e479efecc6c561d75e4ddea58a1bda 
>   org.freedesktop.Telepathy.Client.KTp.ConfAuthObserver.service.in PRE-CREATION 
>   sasl-handler.h dcb34e4d8df86fc79914a1bd34bb17e551a39d63 
>   sasl-handler.cpp d4537258ce6c192401736f260d7fa97b3158ec0a 
>   tls-handler.h 0e036b1ee90d70ba2c46cab28ebf6c7f8e10d148 
>   tls-handler.cpp 038d26d4b4a6cd6fd8083a79c884719db7d72db9 
> 
> Diff: http://git.reviewboard.kde.org/r/107089/diff/
> 
> 
> Testing
> -------
> 
> Opens password dialog when joining a password protected room. Can't make a password protected room, yet, so it's advised to use this in conjuction with pidgin to test.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121028/7c4c3443/attachment-0001.html>