Review Request: Set all contacts to offline when account goes offline

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107385/#review22226
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 19, 2012, 2:56 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107385/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2012, 2:56 p.m.)
> 
> 
> Review request for Telepathy and Vishesh Handa.
> 
> 
> Description
> -------
> 
> The presenceChanged(..) signal is never emitted (bug in tp-qt?) when the account disconnects and so Nepomuk is left with invalid contact presences. This sets all contacts to offline when the connection drops. The presence is re-set when the account is online thanks to the presenceChanged(..) being emitted for all contacts.
> 
> 
> Diffs
> -----
> 
>   contact.h e8d7044 
>   contact.cpp 9bc953d 
> 
> Diff: http://git.reviewboard.kde.org/r/107385/diff/
> 
> 
> Testing
> -------
> 
> Disabling an account sets all contacts as offline. Reenabling it sets them to their presence (though a bit delayed, we might want to tweak this).
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121120/ff606d64/attachment.html>