Review Request: Set all contacts to offline when account goes offline

Martin Klapetek martin.klapetek at gmail.com
Mon Nov 19 14:56:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107385/
-----------------------------------------------------------

Review request for Telepathy and Vishesh Handa.


Description
-------

The presenceChanged(..) signal is never emitted (bug in tp-qt?) when the account disconnects and so Nepomuk is left with invalid contact presences. This sets all contacts to offline when the connection drops. The presence is re-set when the account is online thanks to the presenceChanged(..) being emitted for all contacts.


Diffs
-----

  contact.h e8d7044 
  contact.cpp 9bc953d 

Diff: http://git.reviewboard.kde.org/r/107385/diff/


Testing
-------

Disabling an account sets all contacts as offline. Reenabling it sets them to their presence (though a bit delayed, we might want to tweak this).


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121119/d8fac339/attachment.html>


More information about the KDE-Telepathy mailing list