Review Request: Code tidy in Error Handler

Dan Vrátil dvratil at redhat.com
Tue Nov 13 09:35:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107306/#review21919
-----------------------------------------------------------

Ship it!



error-handler.cpp
<http://git.reviewboard.kde.org/r/107306/#comment16872>

    Fix the typo here too.


- Dan Vrátil


On Nov. 13, 2012, 3:58 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107306/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2012, 3:58 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Code tidy in Error Handler
> 
> add debug output on connection disconnection
>     
> Make slot names in error-handler consistent with KTp
> Fix typo in i18nc comments
> Remove duplicate code
> 
> 
> Diffs
> -----
> 
>   error-handler.h 5c033aa75f23993b18efe5dc708d07bac201a679 
>   error-handler.cpp 5bfe7ae0b79348eea2ddc5bfcd102823e7f6e6a5 
> 
> Diff: http://git.reviewboard.kde.org/r/107306/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121113/faf49736/attachment-0001.html>


More information about the KDE-Telepathy mailing list