<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107306/">http://git.reviewboard.kde.org/r/107306/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107306/diff/1/?file=94701#file94701line74" style="color: black; font-weight: bold; text-decoration: underline;">error-handler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">showMessageToUser</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span class="s">"%1 ist the account name"</span><span class="p">,</span> <span class="s">"Could not connect %1. There was a network error, check your connection"</span><span class="p">,</span> <span class="n">account</span><span class="o">-></span><span class="n">displayName</span><span class="p">()),</span> <span class="n">ErrorHandler</span><span class="o">::</span><span class="n">SystemMessageError</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">showMessageToUser</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span class="s">"%1 ist the account name"</span><span class="p">,</span> <span class="s">"Could not connect %1. There was a network error, check your connection"</span><span class="p">,</span> <span class="n">account</span><span class="o">-></span><span class="n">displayName</span><span class="p">()),</span> <span class="n">ErrorHandler</span><span class="o">::</span><span class="n">SystemMessageError</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix the typo here too.</pre>
</div>
<br />
<p>- Dan</p>
<br />
<p>On November 13th, 2012, 3:58 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2012, 3:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code tidy in Error Handler
add debug output on connection disconnection
Make slot names in error-handler consistent with KTp
Fix typo in i18nc comments
Remove duplicate code
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>error-handler.h <span style="color: grey">(5c033aa75f23993b18efe5dc708d07bac201a679)</span></li>
<li>error-handler.cpp <span style="color: grey">(5bfe7ae0b79348eea2ddc5bfcd102823e7f6e6a5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>