Review Request: Fix build and a crash

[Dan Vrátil]

> On Nov. 11, 2012, 12:28 p.m., Daniele Elmo Domenichelli wrote:
> > Oh interesting... was it created shared before? Because I didn't touch that part...
> > 
> > Anyway ship it!

It had to be, kde-telepathy-0.5 creates the .so file. But you changed some parts around this, so maybe there was some hidden connection


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107272/#review21818
-----------------------------------------------------------


On Nov. 10, 2012, 9:13 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107272/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 9:13 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix build - after Daniele's changes in TpLQt4 buildsystem, "make" does not produce libtelepathy-logger-qt4.so anymore, only .a
> 
> Fix crash - just got a crash when searching in logs, because item->date in some result was NULL
> 
> 
> Diffs
> -----
> 
>   TelepathyLoggerQt4/CMakeLists.txt 1c47376 
>   TelepathyLoggerQt4/pending-search.cpp e4df41a 
> 
> Diff: http://git.reviewboard.kde.org/r/107272/diff/
> 
> 
> Testing
> -------
> 
> make install -> libtelepathy-logger-qt4.so installed
> tried searching - no crash (in TpLQt4)
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121111/7ec8ed93/attachment.html>